search

mennanov / fieldmask-utils

Protobuf Field Mask Go utils
MIT License
229 stars 26 forks source link

Tutorial on how to convert a protobuf message and filter certain fields to a resulting map. #42

Closed marcoshuck closed 4 months ago

marcoshuck commented 5 months ago

This PR addresses the discussion raised in #41

I ended up copying the CamelCase code from the function to my personal open source project to avoid code duplications due to the limitation of the github protobuf project being deprecated, we can remove the dependency if it doesn't make sense to keep it in here.

marcoshuck commented 5 months ago

Seems CI pipelines are failing, looking into it.

mennanov commented 5 months ago

Seems CI pipelines are failing, looking into it.

Yeah, i think i need to upgrade the dependencies and the go version. I'll do that in a separate PR.

mennanov commented 5 months ago

Seems CI pipelines are failing, looking into it.

Yeah, i think i need to upgrade the dependencies and the go version. I'll do that in a separate PR.

I ended up not upgrading the go version in go.mod since it may impact the existing users of the library as according to the docs (https://go.dev/doc/modules/gomod-ref#go):

Go toolchains refuse to use modules declaring newer Go versions.

I updated Github Actions tests for go 1.21 though.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2de6178) 89.27% compared to head (05ee728) 89.27%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #42 +/- ## ======================================= Coverage 89.27% 89.27% ======================================= Files 2 2 Lines 401 401 ======================================= Hits 358 358 Misses 27 27 Partials 16 16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mennanov commented 4 months ago

Thanks for contributing!