search

mennanov / limiters

Golang rate limiters for distributed applications
https://godoc.org/github.com/mennanov/limiters
MIT License
411 stars 47 forks source link

add LockMemcached #32

Closed leeym closed 6 months ago

leeym commented 7 months ago

Hi, @mennanov,

Thank you very much for this interesting library! I really like the clean interface, though in our use case we prefer memcached over redis.

I understand that in extreme situation memcached will evict the oldest entry while redis can be configured to throw errors, but still it is a good trade-off so I plan to add supports for memcached.

I'll start with LockMemcached.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (bc191d0) 83.00% compared to head (6f32228) 83.19%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #32 +/- ## ========================================== + Coverage 83.00% 83.19% +0.18% ========================================== Files 10 10 Lines 1183 1196 +13 ========================================== + Hits 982 995 +13 Misses 137 137 Partials 64 64 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

leeym commented 6 months ago

Obsoleted by https://github.com/mennanov/limiters/pull/33