mennanov / limiters

Golang rate limiters for distributed applications
https://godoc.org/github.com/mennanov/limiters
MIT License
411 stars 47 forks source link

add TestConcurrentBufferDuplicateKeys #35

Closed leeym closed 6 months ago

leeym commented 6 months ago

Adding a new test TestConcurrentBufferDuplicateKeys and fix ConcurrenfBufferMemcached to make sure it follows the other implementations to actually act as a set and handle duplicates correctly.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.46%. Comparing base (9fa00a2) to head (4445182).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #35 +/- ## ========================================== - Coverage 83.51% 83.46% -0.05% ========================================== Files 10 10 Lines 1468 1464 -4 ========================================== - Hits 1226 1222 -4 Misses 169 169 Partials 73 73 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mennanov commented 6 months ago

Feel free to merge when ready

leeym commented 6 months ago

This branch has no conflicts with the base branch

Only those with write access to this repository can merge pull requests.

It looks like I don't have write access to merge it.

mennanov commented 6 months ago

Thanks!