mennanov / limiters

Golang rate limiters for distributed applications
https://godoc.org/github.com/mennanov/limiters
MIT License
458 stars 49 forks source link

add redis cluster client tests #50

Closed leeym closed 5 months ago

leeym commented 5 months ago

I should have done this in https://github.com/mennanov/limiters/pull/48, but I think it is not too late to do it now.

The existing test environment only has single node Redis and there is no Redis cluster. Given that the Redis and Redis cluster may behave differently, I think we should test them separately.

Also run it in two builds:

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.05%. Comparing base (9d9ccea) to head (00de771).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #50 +/- ## ======================================= Coverage 80.05% 80.05% ======================================= Files 12 12 Lines 1449 1449 ======================================= Hits 1160 1160 Misses 212 212 Partials 77 77 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mennanov commented 5 months ago

Awesome! Thanks!