search

mennthor / awkde

Adaptive Width KDE with Gaussian Kernels
MIT License
40 stars 21 forks source link

Try fixing build under Python 3.11 #10

Closed titodalcanton closed 10 months ago

titodalcanton commented 1 year ago

Hello. Building on Python 3.11 fails with the error visible in [1] and [2]. I am not sure why the pybind11 version was being forced to 2.6.x, but removing the pin fixes the error, and the example works with the resulting build.

[1] awkde_error.txt [2] https://github.com/gwastro/pycbc/pull/4243

brandonfcohen1 commented 1 year ago

this worked for me, thanks!

titodalcanton commented 10 months ago

Any chance this could be considered for merging?

mennthor commented 10 months ago

Hi :) Didn't receive notifications, so I didn't notice, sorry. If you already checked everything I'm fine with merging, i didn't touch the code for ages. Can someone quickly explain what this is about?

titodalcanton commented 10 months ago

@mennthor I am not sure I can expand on the description I gave above. What I can say is the code in the main branch no longer works, and it seems to work with this patch. I guess the real question is why the pybind11 version was being forced to 2.6.x in the first place, but I cannot answer that…