menorki / python-calais

Automatically exported from code.google.com/p/python-calais
0 stars 0 forks source link

_get_params_XML must apply XML escapes to values #10

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Use "analyze_url" with a parameterized URL, e.g. 
"http://www.nytimes.com/2009/03/01/magazine/01wwln-lede-t.html?
_r=1&partner=rss&emc=rss&pagewanted=print"

What is the expected output? What do you see instead?
Expect to get a "calais.CalaisResponse" returned; instead, get a ValueError 
reporting that 
"paramsXML is invalid"

What version of the product are you using? On what operating system?
SVN Head (which matches the 1.4 download)

Please provide any additional information below.
Attached is a patch which applies xml.sax.saxutils.escape to the values in 
_get_params_XML. I 
haven't looked to see if there are other places where this should be applied.

Original issue reported on code.google.com by joegermu...@gmail.com on 28 Feb 2009 at 4:26

Attachments:

GoogleCodeExporter commented 9 years ago
Applied.  Thank you very much for your contribution!

Original comment by s3x...@gmail.com on 1 Mar 2009 at 5:59