menpo / cyassimp

Fast Cython bindings for the Open Asset Import Library
Other
7 stars 2 forks source link

limited to meshes supporting triangles, not quads #7

Open jf--- opened 8 years ago

jf--- commented 8 years ago

hi,

I've been delving into assimp and am loading some reference mesh in ~0.33s with cyassimp vs ~1.66s with pyassimp, 5x is pretty sweet. So it seems that the project is developed with a particular objective in mind. I hope its OK if I boldly neglect that in my questions :wink:

Would this have something todo with the numpy interface ( subarrays of mixed ( 3/4 ) length when working with meshes that use both tris & quads? )

Curious to hear if your open to discuss these / interested in contributions.

patricksnape commented 8 years ago

Hi @jf---!

Glad that you found cyassimp useful! I'm taking some credit here, when all of it should really go to @jabooth, but I am very familiar with the project nonetheless.

The long and short of it is, we made cyassimp so that it was useful for our use cases, which was importing single triangular meshes from common formats. If you require quads, we would be very happy to support that! And we are totally open to PRs. I just don't think there is a lot of bandwidth at the moment between us to implement anything ourselves, but we would be happy to aid you! I think it should be pretty simple to support quads to be honest.

Again, with the flags, the default flags were fine for our use cases, but we are happy to support passing of flags.