search

menpo / landmarker.io

Image and mesh annotation web application
https://www.landmarker.io
BSD 3-Clause "New" or "Revised" License
114 stars 21 forks source link

WIP: Migrate towards ljsonv3 #136

Open gabrielcowley opened 7 years ago

gabrielcowley commented 7 years ago

The issue which explains the migration that this PR contributes to can be found here: https://github.com/menpo/landmarker.io/wiki/LEP-0001:-LJSON-v3

This has not yet been fully tested. Dropbox mode needs to be properly tested, Demo mode appears to be working, and landmarkerio-server mode cannot yet be tested as the PR for migrating this towards ljsonv3 is currently a WIP: https://github.com/menpo/landmarkerio-server/pull/24

Old versions of landmarkerio-server need to be detected and a warning shown to encourage the user to use version 3.

gabrielcowley commented 7 years ago

Detection of old landmarkerio-server API versions has been added. Dropbox mode is to be deprecated on ts_react branch, so there is no need to test this. Demo mode is working. Testing has been done against the latest commit in the ljsonv3 landmarkerio-server PR (https://github.com/menpo/landmarkerio-server/pull/24) and it appears to be working. landmarkerio-server was running against the latest commit in the ljsonv3 menpo PR (https://github.com/menpo/menpo/pull/785).