search

menpo / landmarker.io

Image and mesh annotation web application
https://www.landmarker.io
BSD 3-Clause "New" or "Revised" License
114 stars 21 forks source link

Remove Dropbox backend #138

Closed gabrielcowley closed 7 years ago

gabrielcowley commented 7 years ago

_This PR has a staging branch, which means a production build of this branch exists and can be launched. Click here to preview this PR._

The Dropbox backend is removed in this PR. Dropbox API v2 is going to be deprecated soon and so we're removing the backend altogether.

patricksnape commented 7 years ago

Looks good to me

jabooth commented 7 years ago

Unfortunately this is broken for users that are already signed into Dropbox when they visit the new version.

To reproduce:

  1. Go to landmarker.io and sign in to Dropbox
  2. On the same browser, visit landmarker.io/staging/remove_dropbox

What should happen: I should be taken to the main menu What does happen: I get nothing loaded (and no error in the console)

gabrielcowley commented 7 years ago

@jabooth Okay, I'll add a fix for this.

gabrielcowley commented 7 years ago

@jabooth The main menu now opens if Landmarker Server is not the backend type in the application cache.

jabooth commented 7 years ago

Looks great! LGTM.