search

menpo / landmarker.io

Image and mesh annotation web application
https://www.landmarker.io
BSD 3-Clause "New" or "Revised" License
114 stars 21 forks source link

Convert Modal view to React components #140

Closed gabrielcowley closed 7 years ago

gabrielcowley commented 7 years ago

_This PR has a staging branch, which means a production build of this branch exists and can be launched. Click here to preview this PR._

This PR converts the Modal view which is currently a Backbone View into React components and integrates it into the reactbridge.

This PR is to be merged after PR #138.

jabooth commented 7 years ago

@gabrielcowley can you pull and merge ts_react to clean up the diff here?

gabrielcowley commented 7 years ago

@jabooth Will do

gabrielcowley commented 7 years ago

All modals have been converted to React. The Intro modal still exists in Backbone form and the old version is still used for when Landmarker is opened. Replacing this with its React version would require a significant overhaul of the startup process. I'm happy for this to be merged as it is.

jabooth commented 7 years ago

@gabrielcowley OK, in the interest of unblocking let's get this merged, I'll circle back and tidy up the intro stuff later.