search

menpo / landmarker.io

Image and mesh annotation web application
https://www.landmarker.io
BSD 3-Clause "New" or "Revised" License
114 stars 21 forks source link

Get bug free on all latest browsers (Chrome/FF/Safari/Edge) #75

Closed jabooth closed 9 years ago

jabooth commented 9 years ago

Right now the landmarker works without known bugs in Chrome on all platforms. Users should be notified about this if they are in another browser to prevent confusion over bugs.

jabooth commented 9 years ago 
var isChrome = (typeof window.chrome === "object");

seems to be the right way to check http://stackoverflow.com/questions/6339480/how-to-detect-if-a-browser-is-chrome-using-jquery

jabooth commented 9 years ago

Actually Firefox works perfectly now too.

jabooth commented 9 years ago

Latest Safari (iOS 8/OS X 10.10) is now also fine. Only #80 and #81 are currently holding us back from IE 11 support. I'd rather now get those problems solved then the landmarker supports all browsers on all modern platforms - so long as they are up to date.

lirsacc commented 9 years ago

For now the version 2 code doesn't work on IE11 (v1 is ok though) and hasn't worked since January, and a nasty flexbox bug (see https://github.com/Modernizr/Modernizr/issues/1301) makes it look strange.

Even though browser detection is evil, we drop support for now by displaying a prompt on IE, noone complained since January so it shouldn't affect too many people.

jabooth commented 9 years ago

I'm happy to leave IE unsupported frankly, with a prompt suggesting the user installs either Chrome, Firefox, or upgrades to Windows 10 and uses Edge.

I do think that after July 29th we should quickly support Edge, which promises to be easy to support as long as we are suporting WebKit: http://www.neowin.net/news/microsoft-any-edge-to-webkit-differences-are-considered-bugs

jabooth commented 9 years ago

Just checked with Edge and we have no obvious issues. Obliviously it will be an ongoing job to ensure we remain bug free on these browsers but closing this issue for now as the milestone is reached.