search

menpo / landmarker.io

Image and mesh annotation web application
https://www.landmarker.io
BSD 3-Clause "New" or "Revised" License
114 stars 21 forks source link

Navigation keys with fixed position #90

Closed grigorisg9gr closed 9 years ago

grigorisg9gr commented 9 years ago

The position of the navigation keys (previous/next asset) is fixed in case the images have similar size, however it fluctuates greatly in case of different sizes per asset. This can be a bit tricky in case you want to review the images. For instance, you might oscillate between two images, since the 'next' button of an asset might coincide with the 'previous' button of the next asset. E.g. http://bit.ly/1ITl1TU

Therefore, it would be good to have these keys in some fixed position, e.g. in the middle of the images, regardless of the size of the frames.

jabooth commented 9 years ago

linked image so it's kept documented: landmarker_issue

@lirsacc: interesting issue @grigorisg9gr is seeing - the middle flexbox (containing the paging keys) should always been centred. If you want to take a look whilst looking into the other layout bug that would be great.

lirsacc commented 9 years ago

This happens because the left flex is not fixed width and adapts to the asset id text, not related to image width though.

Easy to fix to lock the arrows in place, but the left UI still risks overflowing horizontally so I would propose either putting the index before the id or below (to be consistent for any length and avoid having it in the middle of the second line). Any preference @jabooth ?

jabooth commented 9 years ago

Ah of course! Let's go with the second solution - index below asset id.