menpo / landmarker.io

Image and mesh annotation web application
https://www.landmarker.io
BSD 3-Clause "New" or "Revised" License
114 stars 21 forks source link

Uncaught TypeError: Cannot read property 'deselectAll' of undefined #98

Closed lirsacc closed 9 years ago

lirsacc commented 9 years ago

With erroception logging, we get a lot of errors of the type 'cannot call deselectAll of undefined' or 'cannot call insertNew of undefined'.

They seem to be caused by the viewport event handlers which are not guarded and during an asset switch all the objects are swapped out and thus undefined if anyones clicks or hits a key.

lirsacc commented 9 years ago

Fixed with https://github.com/menpo/landmarker.io/commit/06497792bb526dc63cdd3e0b9f6af70317f2f1a7