menpo / menpo3d

Tools for manipulating 3D meshes within the Menpo project.
http://www.menpo.org
Other
165 stars 55 forks source link

NICP hangs in Jupyter notebook #87

Open apapaion opened 1 year ago

apapaion commented 1 year ago

When NICP (non_rigid_icp etc) is called in a Jupyter notebook, the operation hangs. Tested in ipykernel 6.3.1 with ipython 7.27.0 and and ipython 8.4. There is no such issue in Ipykernel 5.5.3 and ipython 7.22.0. The issue is with sys.stdout.close(), which hangs (perhaps it has to do with issue 868 at ipykernel project). Also, in the same matter, fileno has a different behaviour in the newer versions as it does not raise an UnsupportedOperation exception. Perhaps is it better to check __IPYTHON__ instead of fileno ?