Closed paullryan closed 11 years ago
It's a good thought, but there aren't any tests in here currently to run as a bellwether - everything under test/
is just a stub. Might be worthwhile to build out some basic smoke tests to have something initially to run.
That was my thought too but I figured if we're going to do that we should have it hooked up to run on travis as we get those in :) That way we can verify that we don't break each-other without having to depend on each committer or each person given a pull request being disciplined about running said tests. To me ci, if feasible, is always more reliable than human run.
I know I have the tendency to forget or omit testing if I'm in a hurry and this will automatically enforce some level of discipline, given that we create tests that is.
If you have time to implement this is a great suggestion.
-robert
On May 6, 2013, at 1:41 PM, Paul Ryan notifications@github.com wrote:
That was my thought too but I figured if we're going to do that we should have it hooked up to run on travis as we get those in :) That way we can verify that we don't break each-other without having to depend on each committer or each person given a pull request being disciplined about running said tests. To me ci, if feasible, is always more reliable than human run.
I know I have the tendency to forget or omit testing if I'm in a hurry and this will automatically enforce some level of discipline, given that we create tests that is.
— Reply to this email directly or view it on GitHub.
Hey @menro can you hook repository to travis-ci so I can start working through this on a branch. To do this you need to go to settings, then click on service hooks, scroll down to travis and follow the instructions given.
Thanks.
Done.
On May 22, 2013, at 3:29 PM, Paul Ryan notifications@github.com wrote:
Hey @menro can you hook repository to travis-ci so I can start working through this on a branch. To do this you need to go to settings, then click on service hooks, scroll down to travis and follow the instructions given.
Thanks.
— Reply to this email directly or view it on GitHub.
@nadeemyasin61 Any ideas why in the test environment I get the following when I run the rake system:bootstrap
?
== Seed from /Users/pryan/workspaces/NewTech/db/fixtures/009_roles.rb
rake aborted!
uninitialized constant SeedFu::Runner::Role
Models is present in my branch and I can's see anything in the configs that would cause this...
Thanks for any help.
This issue is closed with my most recent commit.
To make sure we don't break each other I'll get a yml file for travis in place so that we can have travis build this project on each commit. This should help keep the build clean.