mensatt / frontend

2 stars 2 forks source link

feat: Change mensa (fav) highlighting #21

Closed stormofice closed 2 months ago

stormofice commented 2 months ago

image

Bin nicht 100% zufrieden, aber finde es besser als davor (selection = grün, herzen = rot :3)

Zu lösendes Problem war, dass die selektierte Option nicht erkennbar ist und mit der grünen Hinterlegung der gefavten Optionen verwirrend ist. Allerdings ist der Ansatz hier potentiell auch ein bisschen komisch, da jetzt die gefavten Optionen in den Hintergrund rücken,

Thoughts?

netlify[bot] commented 2 months ago

Deploy Preview for mensatt-nuxt ready!

Name Link
Latest commit fe0f8bfe7dee5f6a728830620f24979c0689cb77
Latest deploy log https://app.netlify.com/sites/mensatt-nuxt/deploys/660b0b9f06000e0008b98d8c
Deploy Preview https://deploy-preview-21--mensatt-nuxt.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

maanex commented 2 months ago

I'm fine with de-coupling the background from the favourites feature, but I do not see red fitting here at all :/ how would it look like with the old green hearts back?

stormofice commented 2 months ago

I tested it with the green hearts before, didn't fully like the look either: image Still fits better I guess?

edit: I think my issue is that it is clear enough that the entries are pinned to the top. Maybe a separator line between the favorite ones and the rest would work?

maanex commented 2 months ago

maybe we could swap the heart icon out for a pin icon?

stormofice commented 2 months ago

1: image 2: image 3: image

Prefs?

maanex commented 2 months ago

I think I used material symbols for the rest of the icons so preferably the pins from that icon set for consistency https://icones.js.org/collection/material-symbols?s=keep+rounded

stormofice commented 2 months ago

Ah, only found iconfiy in the NuxtIcon docs, so I searched there.

image

Looks good?

maanex commented 2 months ago

Hm... Visually I like the hearts better but pushpins are clearer in their function... Idk

stormofice commented 2 months ago

I think I prefer the hearts, even though it may be a bit confusing at first

stormofice commented 2 months ago

locking in...