search

mental32 / spotify.py

🌐 API wrapper for Spotify 🎶
https://spotifypy.readthedocs.io/en/latest/
MIT License
150 stars 38 forks source link

Refresh the token when a request fails - v0.8.2 #42

Closed micahdlamb closed 4 years ago

micahdlamb commented 4 years ago

I rebased the changes from Pull Request #40 onto v0.8.2.

I also snuck in a fix to the user.library.save_tracks function.

mental32 commented 4 years ago

looks good to me, have the changes been tested?

micahdlamb commented 4 years ago

Yea I quickly manually tested it after rebasing. Its probably a good idea for me to test more thoroughly this evening. I wish there was an easy way to make an automated test.

On Tue, Nov 19, 2019, 3:53 AM mental notifications@github.com wrote:

looks good to me, have the changes been tested?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mental32/spotify.py/pull/42?email_source=notifications&email_token=AAYIZABMH5D53TOXWCY6BWLQUOSQZA5CNFSM4JO4RNNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEENLR2Y#issuecomment-555399403, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYIZAF7TUKXXH22BKRE2JTQUOSQZANCNFSM4JO4RNNA .

mental32 commented 4 years ago

Yea I quickly manually tested it after re basing. Its probably a good idea for me to test more thoroughly this evening. I wish there was an easy way to make an automated test.

That's fine, I can merge this now. If there are any more issues you find with testing comment on this thread and we can figure out a way to re base the fixes.