search

mental32 / spotify.py

🌐 API wrapper for Spotify 🎶
https://spotifypy.readthedocs.io/en/latest/
MIT License
150 stars 38 forks source link

When using album.get_all_tracks(), an error is produced. `'Nonetype' has no attribute 'images'` #59

Closed aaronhnsy closed 4 years ago

aaronhnsy commented 4 years ago

Error is as the title says. Heres here traceback.

AttributeError: 'NoneType' object has no attribute 'images'
Traceback (most recent call last):
  File "C:\Users\mynam\Downloads\PycharmProjects\Life\venv\lib\site-packages\discord\ext\commands\core.py", line 83, in wrapped
    ret = await coro(*args, **kwargs)
  File "C:\Users\mynam\Downloads\PycharmProjects\Life\Life\cogs\voice\music.py", line 70, in play
    search_result = await ctx.player.get_results(ctx=ctx, search=search)
  File "C:\Users\mynam\Downloads\PycharmProjects\Life\Life\cogs\voice\utilities\player.py", line 97, in get_results
    spotify_tracks = await result.get_all_tracks()
  File "C:\Users\mynam\Downloads\PycharmProjects\Life\venv\lib\site-packages\spotify\models\album.py", line 125, in get_all_tracks
    return [track async for track in self]
  File "C:\Users\mynam\Downloads\PycharmProjects\Life\venv\lib\site-packages\spotify\models\album.py", line 125, in <listcomp>
    return [track async for track in self]
  File "C:\Users\mynam\Downloads\PycharmProjects\Life\venv\lib\site-packages\spotify\models\base.py", line 145, in __aiter__
    yield klass(client, item)  # pylint: disable=not-callable
  File "C:\Users\mynam\Downloads\PycharmProjects\Life\venv\lib\site-packages\spotify\models\track.py", line 78, in __init__
    self.images = album.images.copy()

I think this may be an api change as only a week ago with the same album this function worked normally, Now it is broken.

mental32 commented 4 years ago

Thanks for reporting this!

will investigate this now :)

aaronhnsy commented 4 years ago

Hi, sorry for getting back to you late, this fix works fine thanks