Refactoring - Githubissues

mentaljam / standard_paths

A Rust port of QStandardPaths class which provides methods for accessing standard paths on the local filesystem (config, cache, user directories and etc.).

https://docs.rs/crate/standard_paths

MIT License

7 stars 1 forks source link

Refactoring #6

Closed Shatur closed 2 years ago

Shatur commented 2 years ago

I fixed comments in folerid_generator (was broken after cargo fmt). BTW, what is this example for?
Enabled clippy checks on examples and fixed warnings.
Implemented Copy on enums. Enum values that smaller then pointer are faster to pass by value.
Upgraded to Rust 2021. The only thing that I had to change was modules inclusion.
Use home crate (used even by Cargo!) instead of deprecated std::env::home_dir().
Hide extra pub functions.
Fix markdown doc and enable clippy::doc_markdown.

mentaljam commented 2 years ago

I fixed comments in folerid_generator (was broken after cargo fmt). BTW, what is this example for?

It's output is used in src/windows.rs. I don't remember why I've decided to implement it as an example but not a build script.

Shatur commented 2 years ago

It's output is used in src/windows.rs. I don't remember why I've decided to implement it as an example but not a build script.

Got it. Let's left it as is for now.

I planned some more changes, but I assume this can be merged as is if you agree on this PR.

mentaljam commented 2 years ago

I think you can continue committing to this PR. If you need take a break, I'll merge it and publish a release

Shatur commented 2 years ago

I think you can continue committing to this PR.

Okay! I will continue today after work :)

Shatur commented 2 years ago

Done!

Shatur commented 2 years ago

@mentaljam I think I'm done, please merge and publish a release :)

mentaljam commented 2 years ago

Great! Thank you again!