mentat-collective / emmy

The Emmy Computer Algebra System.
https://emmy.mentat.org
GNU General Public License v3.0
405 stars 24 forks source link

Remove extra slot for metadata #147

Open sritchie opened 1 year ago

sritchie commented 1 year ago

TODO: decide if this actually works in all cases for the affected types. Am I always hanging metadata off something that can take it?

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 53.70% and project coverage change: -0.11% :warning:

Comparison is base (e16b569) 86.05% compared to head (4320644) 85.95%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #147 +/- ## ========================================== - Coverage 86.05% 85.95% -0.11% ========================================== Files 98 98 Lines 15335 15295 -40 Branches 834 827 -7 ========================================== - Hits 13197 13147 -50 - Misses 1304 1321 +17 + Partials 834 827 -7 ``` | [Files Changed](https://app.codecov.io/gh/mentat-collective/emmy/pull/147?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/emmy/structure.cljc](https://app.codecov.io/gh/mentat-collective/emmy/pull/147?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2VtbXkvc3RydWN0dXJlLmNsamM=) | `88.04% <45.71%> (-0.04%)` | :arrow_down: | | [src/emmy/series.cljc](https://app.codecov.io/gh/mentat-collective/emmy/pull/147?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2VtbXkvc2VyaWVzLmNsamM=) | `59.01% <46.23%> (-2.78%)` | :arrow_down: | | [src/emmy/operator.cljc](https://app.codecov.io/gh/mentat-collective/emmy/pull/147?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2VtbXkvb3BlcmF0b3IuY2xqYw==) | `76.08% <72.72%> (-1.65%)` | :arrow_down: | | [src/emmy/polynomial.cljc](https://app.codecov.io/gh/mentat-collective/emmy/pull/147?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2VtbXkvcG9seW5vbWlhbC5jbGpj) | `83.28% <100.00%> (ø)` | | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/mentat-collective/emmy/pull/147/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.