search

mentatpsi / OSGenome

An Open Source Web Application for Genetic Data (SNPs) using 23AndMe and Data Crawling Technologies
GNU General Public License v3.0
119 stars 17 forks source link

Use latest beautifulsoup #18

Closed sangaman closed 2 years ago

sangaman commented 2 years ago

This enables support for python 3.10, and should still work with python 3.6+ according to the BeautifulSoup website.

Fixes #17

mentatpsi commented 2 years ago

No PRs are accepted on this branch given nature of code. I've implemented your change.

sangaman commented 2 years ago

No PRs are accepted on this branch given nature of code. I've implemented your change.

Just curious but what do you mean by this? What nature?

mentatpsi commented 2 years ago

The software links up your genetics locally. There are privacy concerns with SNP data. I personally designed this software so that users can feel safe about their genetic data. I like to keep the code closed off so users don't need to worry about the code origins. Sorry I couldn't give you a PR request for your work on this ticket. I appreciate your work though debugging this issue.

mentatpsi commented 2 years ago

I've given you credit in this issue ticket: https://github.com/mentatpsi/OSGenome/issues/17

mentatpsi commented 2 years ago

Also provided credit on the commit itself: https://github.com/mentatpsi/OSGenome/commit/cf798c12271c980bf029e84d3c2c104cf7d1acd7

mentatpsi commented 2 years ago

Hope this is adequate for your work on this issue.

mentatpsi commented 2 years ago

Decided to merge it. I realized your work, research, and time will get lost if it's not merged. Thanks again.

sangaman commented 2 years ago

Decided to merge it. I realized your work, research, and time will get lost if it's not merged. Thanks again.

Thanks! I wasn't offended or anything but I appreciate the credit. IMO, plenty of open source projects that handle critical or sensitive data accept PRs, which is fine as long as they're well reviewed and well understood.

Thanks for putting this project together, it was fun and interesting to use.