search

mentatpsi / OSGenome

An Open Source Web Application for Genetic Data (SNPs) using 23AndMe and Data Crawling Technologies
GNU General Public License v3.0
119 stars 17 forks source link

>2x speedup of crawling SNPedia #24

Closed mikolajz closed 8 months ago

mikolajz commented 8 months ago

Maybe you are interested in this as well

mentatpsi commented 8 months ago

Hi,

There is considerable documentation on the presence of ambiguous flips related to orientation that prevent me from wanting to merge this code.

Additionally, these code changes are to the fundamental structure of the application that I'd like to avoid making changes to.

mentatpsi commented 8 months ago

Looking through the changes, they are very nicely thought out and do look like good improvements. Don't intend any insult, your coding is very good :).

mentatpsi commented 8 months ago

Let me know if you ever need a recommendation :)

mikolajz commented 7 months ago

No problem. I will continue working on it in my fork, since I want to add VCF file support to get a bigger picture. Once it's done, maybe it will be worth to add a link from your README to my tree?

mentatpsi commented 7 months ago

Regarding VCF file support, please see the below: Bioinformatics Stack Exchange: Converting a Dante Lab VCF file

mentatpsi commented 7 months ago

As well as Bioinformatics Stack Exchange: How to Generate RSID values locally from VCF file