Avoid undefining _FORTIFY_SOURCE unnecessarily

mentebinaria / readpe

The PE file analysis toolkit

GNU General Public License v2.0

676 stars 128 forks source link

Avoid undefining _FORTIFY_SOURCE unnecessarily #167

Closed davidpolverari closed 3 years ago

davidpolverari commented 3 years ago

The build systems of some Linux distros (like Debian) make use of _FORTIFY_SOURCE in more secure levels than stated by pev. This patch only defines _FORTIFY_SOURCE if it has not been defined before.

The previous approach of undefining and defining it unconditionally caused a weakening of the hardening expected by those distros' build systems. This patch keeps the same functionality as before, while allowing for distros to use more secure levels if so they wish.

merces commented 3 years ago

Thanks for that!

davidpolverari commented 3 years ago

Thanks for that!

You're welcome!