mento-protocol / governance-ui

An open source interface for the Mento protocol governance
https://governance.mento.org
0 stars 0 forks source link

Feat(109): Connected dropdown style fixes #110

Closed RyRy79261 closed 4 months ago

RyRy79261 commented 4 months ago

Overview

This PR fixes some styling mismatches and should now match the designs

Review process

Related issues

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
governance-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 9:03pm
bayological commented 4 months ago

I am wondering if we should use some icons for the menu items; also, the weight on the token names looks like it should be reduced.

Designs: image

Branch: image

RyRy79261 commented 4 months ago

@baroooo We dont have icons for those buttons available. I looked through the Figma component library and didn't see any appropriate ones

RyRy79261 commented 4 months ago

@baroooo Ahh its actually a different font in the drop down, made some updates

RyRy79261 commented 4 months ago

The dark mode design uses a different button all together, so I assumed it was deprecated. There isn't any reference for what the different button styles specifically look like in dark mode, to change the type entirely I'd need to do that via react instead of media queries

RyRy79261 commented 4 months ago

image

baroooo commented 4 months ago

The dark mode design uses a different button all together, so I assumed it was deprecated. There isn't any reference for what the different button styles specifically look like in dark mode, to change the type entirely I'd need to do that via react instead of media queries

If this is ok as it is, the rest looks good ✅