search

mento-protocol / governance-ui

An open source interface for the Mento protocol governance
https://governance.mento.org
0 stars 0 forks source link

Feat/19 allow users to view all proposals #45

Closed AnnaJ-P11 closed 7 months ago

AnnaJ-P11 commented 7 months ago

Description

handle the supports field, add votes schema, queries, create resolvers, policies, add new data to ui

Other changes

n/a

Tested

PR build and lint successful

Related issues

Backwards compatibility

n/a

Documentation

n/a

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
governance-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2024 10:57am
AnnaJ-P11 commented 7 months ago

https://github.com/mento-protocol/governance-ui/pull/19

bowd commented 7 months ago

We need to do something about the proposal ID. The actual ID is too long and breaks the UI. If the results of the get proposals query are ordered I'd propose using the index of the proposal but open to other suggestions here. @bowd @olenovyk

I think using the index is inconsistent. It doesn't give you information. The same proposal will first get an index of 1, and when a new proposal gets created, it will have an index of 2, and the new one will get index 1. That doesn't give much value or information and might lead to confusion.

I see a few options:

  1. Remove that column all together
  2. Just use the first 8 characters of the ID as a sort of "shorthand" proposal id. Then it's at least unique and tied to the proposal and consistent.
  3. Use a blockies type icon derived from the proposalId.

I would be happy with (1) or (2).

@bayological / @olenovyk / @AnnaJ-P11

olenovyk commented 7 months ago

We need to do something about the proposal ID. The actual ID is too long and breaks the UI. If the results of the get proposals query are ordered I'd propose using the index of the proposal but open to other suggestions here. @bowd @olenovyk

I think using the index is inconsistent. It doesn't give you information. The same proposal will first get an index of 1, and when a new proposal gets created, it will have an index of 2, and the new one will get index 1. That doesn't give much value or information and might lead to confusion.

I see a few options:

  1. Remove that column all together
  2. Just use the first 8 characters of the ID as a sort of "shorthand" proposal id. Then it's at least unique and tied to the proposal and consistent.
  3. Use a blockies type icon derived from the proposalId.

I would be happy with (1) or (2).

@bayological / @olenovyk / @AnnaJ-P11

let's remove this column