search

mento-protocol / governance-ui

An open source interface for the Mento protocol governance
https://governance.mento.org
0 stars 1 forks source link

Fix/362 fix warning by refactor Countdown component #53

Closed AnnaJ-P11 closed 8 months ago

AnnaJ-P11 commented 9 months ago

Description

Fix warning in console: "Maximum update depth exceeded" on Single Proposal Page by Refactor Countdown component Added calculation of the end time, needed in the Countdown component

Other changes

n/a

Tested

PR build and lint successful

Related issues

Backwards compatibility

n/a

Documentation

n/a

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
governance-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 5:20pm
AnnaJ-P11 commented 9 months ago

@bayological Unfortunately after recent merges showing proposal details does'nt work. I've tested this task by hardcoding proposal data and commenting whole code od single proposal page except Countdown. I think that after completing the task of displaying proposal details #22 , it will be possible to test this task locally.

bayological commented 9 months ago

@bayological Unfortunately after recent merges showing proposal details does'nt work. I've tested this task by hardcoding proposal data and commenting whole code od single proposal page except Countdown. I think that after completing the task of displaying proposal details #22 , it will be possible to test this task locally.

Okay I will check it the same way.