Closed RyRy79261 closed 5 months ago
vercel[bot]
commented
6 months ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| governance-ui | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Mar 22, 2024 0:14am |
chapati23
commented
6 months ago We should use an eslint plugin for imports tbh, not in this PR but good future cleanup
On 18. Mar 2024, at 16:43, Denvil J Clarke @.***> wrote:
@denviljclarke commented on this pull request.
In src/app/(routes)/create-proposal/page.tsx https://www.google.com/url?q=https://github.com/mento-protocol/governance-ui/pull/80%23discussion_r1528807749&source=gmail-imap&ust=1711381401000000&usg=AOvVaw0i8ej1XlzeY56tYklYFkVl:
@@ -0,0 +1,28 @@ +"use client"; +import { useEffect } from "react"; As we're doing a bit of a cleanup nit - unused import
— Reply to this email directly, view it on GitHub https://www.google.com/url?q=https://github.com/mento-protocol/governance-ui/pull/80%23pullrequestreview-1943473835&source=gmail-imap&ust=1711381401000000&usg=AOvVaw0VOWnXp1AChLaIR-X1sfuM, or unsubscribe https://www.google.com/url?q=https://github.com/notifications/unsubscribe-auth/AAA4V5Z5K2JTB5P26IG5ZZTYY4DRPAVCNFSM6AAAAABEW7MBFOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNBTGQ3TGOBTGU&source=gmail-imap&ust=1711381401000000&usg=AOvVaw2uU8rI3ameDP-BXb_qto3o. You are receiving this because your review was requested.
denviljclarke
commented
6 months ago Nice work @RyRy79261, it looks good overall. I left a few comment & scheduled a walkthrough with you 😁
Overview
This PR restructures the repo to align with NextJS app folder structure as well as remove
zustandbased store management.Reviewing
Given the wide scope of changes, and the development processes going forward, I would recommend having a group walkthrough to review
Changelog
zustandstate removed and moved into Tanstack via wagmipnpmnextjsapp folder recommendationsRelated issues