mento-protocol / mento-core

Core smart contracts of the Mento protocol.

https://mento.org

GNU General Public License v3.0

24 stars 11 forks source link

feat: remove stop and start #410

Closed baroooo closed 7 months ago

baroooo commented 7 months ago

Description

This PR removes stop functionality from locking contracts to fix Sherlock contest finding 14

Main reason why we decided to remove it altogether instead of applying the fixes is, after a stop, balanceOf returns 0 for all accounts, which might cause bricking the whole governance.

Other changes

Tests

Removed related unit tests

Related issues

Fixes #406

openzeppelin-code[bot] commented 7 months ago

feat: remove stop and start

Generated at commit: 40f7eb3b5994cdf970a4b823697fb5b8a969de16

🚨 Report Summary

Severity Level Results

Contracts Critical
High
Medium
Low
Note
Total 3
3
0
13
38
57

Dependencies Critical
High
Medium
Low
Note
Total 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	3 3 0 13 38 57
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0