mento-protocol / mento-core

Core smart contracts of the Mento protocol.
https://mento.org
GNU General Public License v3.0
20 stars 10 forks source link

feat: implement a relayer version that uses in-memory arrays #494

Closed bowd closed 1 month ago

bowd commented 1 month ago

Side-hustle of #487 to turn immutable variables into an in-memory array for aggregators.

bowd commented 1 month ago

@m-chrzan @philbow61 @chapati23

So I wanted to test out the ergonomics of this option as well, the gas-penalty compared to not using arrays is around <2k gas which is <1% of gas cost for transactions. We still get the silly nested ifs but a bit more isolated and just in order to build the array. What do y'all think?

openzeppelin-code[bot] commented 1 month ago

feat: implement a relayer version that uses in-memory arrays

Generated at commit: 69a00e81d9832c7ee7690c8d5b70b970701ff2fb

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
3
3
0
13
38
57
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector