mento-protocol / mento-web

A simple DApp for Celo Mento exchanges
https://app.mento.org
Apache License 2.0
22 stars 14 forks source link

[bug] Swap Error - Rounding issue #107

Closed denviljclarke closed 3 weeks ago

denviljclarke commented 12 months ago

Description

There's still a rounding issue causing swaps to fail after approvals and before the swap transaction in the transaction preparation step. This is likely due to a rounding error as it only happens in some cases when the 'use max' feature is used. A quick fix could be to swap slightly less than the max balance, some negligible amount ( .00001 ).

This can be reproduced by having a balance of USDC or any bridged version, selecting it as the input token then clicking the use max button.

Acceptance Criteria

Once swaps are approved they should be approved and executed with no issue