search

mentos1386 / nest-raven

Sentry Module for Nest.js Framework
MIT License
249 stars 26 forks source link

Websocket Support #9

Closed ryanpager closed 5 years ago

ryanpager commented 5 years ago

Question -- Does the module support exceptions thrown from Websocket event gateways? I have it setup just like you have it as a global interceptor; and it seems to not catch anything. Just trying to figure out if I am screwing something up or not. Appreciate it!

mentos1386 commented 5 years ago

Hey @ryanpager sorry for late reply. I have totally forgot about the websocket gateways. I'll write some test cases tomorrow to try it out.

mentos1386 commented 5 years ago

@ryanpager strangly it doesn't work with global interceptor, but it works fine with method or class wide interceptor. It could be a nestjs issue and not this library specifically. I'll open an issue on nest repository and link it here.

ryanpager commented 5 years ago

@mentos1386 I appreciate ya -- ill just add it as a class wide interceptor for now! Thanks a bunch for checking.

mentos1386 commented 5 years ago

Not a bug. Global interceptors (and guards) aren't applied to gateways by design.