search

mentrena / SyncKit

Automatic CloudKit synchronization
https://mentrena.github.io/SyncKit/
MIT License
507 stars 59 forks source link

Missing data when accepting share for the 2nd time #128

Closed BlixLT closed 2 years ago

BlixLT commented 4 years ago

Something is wrong with shared db synchronizer's logic. Looks like it cannot work the same as private db synchronizer. Lets say userA created companyA, added EmpoyeeA, EmployeeB to it and shared to userB. UserB sees companyA (with EmpoyeeA and EmployeeB). userB adds EmployeeC to it. Both - owner (userA) and userB sees all 3 emplyees. UserA stops sharing account -> it disappears from userB shared db. UserA shares it again to userB, userB accepts it, but only EmployeeA and EmployeeB are being downloaded by SyncKit this time. EmployeeC is being ignored (because last change was made on userB device and that change is being ignored).

BlixLT commented 4 years ago

The best solution I could come up with is to reset deviceIdentifier/deviceUUID when accepting any? share. That way these changes (when accepting previously accepted/left share) would not be ignored. Not the ideal solution, but I suppose it should work.

BlixLT commented 4 years ago

Apparently my suggestion does not work: If you have more than 1 device, accept that share for the second time on 1 of them, the other one(s) downloads records/changes of that share, but ignore changes that were previously made on that device. So, resetting device identifier might work (= probably fix this issue) only on device that is accepting share for the second time, but all other that user's devices will ignore some changes (the ones that were made on these devices before leaving a share). Any ideas what can be done here?

aehlke commented 2 years ago

did you find the logic in this codebase?

mentrena commented 2 years ago

This should be fixed in 1.3.2, thanks!