search

mentrena / SyncKit

Automatic CloudKit synchronization
https://mentrena.github.io/SyncKit/
MIT License
506 stars 57 forks source link

missing completion handler call #96

Closed BlixLT closed 4 years ago

BlixLT commented 4 years ago

It looks like to be a bug here - if a method has a completion block I suppose it to be called before returning from the method (always or at least in most circumstances).

mentrena commented 4 years ago

That looks good. Could you maybe add a case to SyncError in CloudKitSynchronizer.swift and return that error here?

BlixLT commented 4 years ago

Something like that?

mentrena commented 4 years ago

Thanks! Let me know if you need me to do a release, otherwise I might try to look at the other issues before releasing.

BlixLT commented 4 years ago

No need (for me) to do a release just with this fix - the other issues I submitted are more important.