search

menuet / conan-sfml

conan recipe for sfml
MIT License
0 stars 0 forks source link

Modifications for Bincrafters Inclusion #1

Open solvingj opened 6 years ago

solvingj commented 6 years ago

Hi Pascal,

Here is a list of items you'll want to address before you push to bincrafters:

We have conan packages for about half of the dependencies listed. Please add them in under the requires() attribute. Then, lets determine the remaining list of libraries which we don't have packaged, and determine which of those are "rarely installed on linux by default". We can then consider packaging those. For example, we will probably not package all the x11's and Pthread, but maybe openal and opengl. As a last resort, we can add them to the recipe as system_requirements() if they're pretty uncommon and too hard to package.

menuet commented 6 years ago

ok thanks for your time and your feedback. I will proceed with the changes when I have time and let you know.

----- Mail original ----- De: "Jerry" notifications@github.com À: "menuet/conan-sfml" conan-sfml@noreply.github.com Cc: "Subscribed" subscribed@noreply.github.com Envoyé: Mardi 23 Janvier 2018 17:10:23 Objet : [menuet/conan-sfml] Modifications for Bincrafters Inclusion (#1)

Hi Pascal,

Here is a list of items you'll want to address before you push to bincrafters: 

*

Remove .vscode directory

Comment out the MinGW builds in appveyor for now

Clear all the templated comments from conanfile.py

Remove all the non-templates stuff (apt-get installs) from .travis.yml It's not needed because CPT uses docker images which have all the required packages. We actually don't use the OS of the travis VM for anything other than downloading sources, and then invoking the docker images.

Regarding your note here: https://github.com/menuet/conan-sfml/blob/master/conanfile.py#L53

We have conan packages for about half of the dependencies listed. Please add them in under the requires() attribute. Then, lets determine the remaining list of libraries which we don't have packaged, and determine which of those are "rarely installed on linux by default". We can then consider packaging those. For example, we will probably not package all the x11's and Pthread, but maybe openal and opengl. As a last resort, we can add them to the recipe as system_requirements() if they're pretty uncommon and too hard to package.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub , or mute the thread .