meom-group / eophis

Couple Python and Machine Learning models with Geophysical simulation codes through OASIS
https://eophis.readthedocs.io/en/latest/
MIT License
9 stars 1 forks source link

OASIS abort if too high RUNTIME value - Correction #32

Closed alexis-barge closed 1 month ago

alexis-barge commented 1 month ago

OASIS parser is limited to 8 digits numbers when reading exchanges frequencies. If defining STATIC exchanges with RUNTIME bigger than 8 digits, OASIS will read truncated values. Leading to synchronicty errors.

For instance:

Correction : raise an error from Eophis if STATIC frequency is too high. Error tells user to lower ITER*DT and run several segments instead , or not to use STATIC exchange, or to upgrade to at least v1.1.x.

preprod mode : check and raise error in namcouple._finalize --> -1 STATIC and RUNTIME known prod mode : during make_and_check() --> RUNTIME known from read namcouple and STATIC are spotted for check

alexis-barge commented 1 month ago

Done with #37