I think the some functions (fill_nan, retrieve_segments, plot_psd) could be more flexible:
allow to fill nan or compute the PSD for different variables than only mdt + ssha by adding a parameter specifying the name of the targeted variable (functions fill_nan, retrieve_segments),
allow to plot more than 2 PSD (with custom labels) and allow for unit to be different that $m^2$ (function plot_psd).
I also believe that some performance improvements could be achieved by using a ProcessPoolExecutor to parallelize the retrieval of segments (retrieve_segments) and the computation of the PSD (calculate_psd).
I also have a PR ready, let me know what you think!
Hi,
I think the some functions (
fill_nan
,retrieve_segments
,plot_psd
) could be more flexible:mdt + ssha
by adding a parameter specifying the name of the targeted variable (functionsfill_nan
,retrieve_segments
),plot_psd
).I also believe that some performance improvements could be achieved by using a
ProcessPoolExecutor
to parallelize the retrieval of segments (retrieve_segments
) and the computation of the PSD (calculate_psd
).I also have a PR ready, let me know what you think!
Vadim