meow-edit / meow

Yet another modal editing on Emacs / 猫态编辑
GNU General Public License v3.0
1.07k stars 128 forks source link

Consider local keybindings when moving commands for the Motion state. #517

Closed okamsn closed 3 months ago

okamsn commented 7 months ago

This seems to fix using the overrides in Magit buffers (see #493), where the command bound to H-k seems to be based on where point is located when meow--save-origin-commands is run.

DogLooksGood commented 7 months ago

Hey, thanks for the contribution.

We want to keep meow free of dependencies, so we don't want to introduce compact library. I guess we can port it if we really need it.

okamsn commented 7 months ago

OK, I've removed the use of Compat and copied the relevant portion of the definition.

This change works for me on Emacs 29.1. What else would you like changed?

DogLooksGood commented 7 months ago

I'm quite busy these days. Later I'll check the updates and merge.

norris-young commented 4 months ago

@DogLooksGood This works for me. Will you merge it?

DogLooksGood commented 4 months ago

I'll do some test and merge it.