Closed okamsn closed 3 months ago
Hey, thanks for the contribution.
We want to keep meow free of dependencies, so we don't want to introduce compact
library. I guess we can port it if we really need it.
OK, I've removed the use of Compat and copied the relevant portion of the definition.
This change works for me on Emacs 29.1. What else would you like changed?
I'm quite busy these days. Later I'll check the updates and merge.
@DogLooksGood This works for me. Will you merge it?
I'll do some test and merge it.
Add the library Compat (https://elpa.gnu.org/packages/compat.html), which makes available the function
keymap-local-lookup
to Emacs older than 29.1. The newkeymap-
functions are recommended over older functions likelookup-key
.Instead of directly binding
H-j
to what was bound toj
, for example, bindH-j
to an interactive lambda which first checks whether there is a local binding forj
. If there is, use that. If there is not, then call the orignal command bound toj
.This seems to fix using the overrides in Magit buffers (see #493), where the command bound to
H-k
seems to be based on where point is located whenmeow--save-origin-commands
is run.