meowwtama / pe

0 stars 0 forks source link

Better error message could be provided #9

Open meowwtama opened 6 months ago

meowwtama commented 6 months ago

Screenshot 2024-04-19 at 5.04.03 PM.png

In the context of a large address book, the last index of the contact would be hard to find as users would have to scroll to the end.

The error message stating an index is invalid is vague as it does not tell us why, in this case 3, is invalid as it is a positive index. Should state that index is out of range or smth like that.

soc-se-bot commented 6 months ago

Team's Response

To address the first concern that users have to scroll to the end, the remove command actually works in a filtered list, which is achieved when used in conjunction with the find command, as indicated in the tip here:

image.png

The first concern is hence not a bug.

For the second concern about "The error message stating an index is invalid is vague as it does not tell us why, in this case 3, is invalid as it is a positive index.", it is actually more of a feature flaw (not functionality bug - which means product does not work as expected), but it is a feature flaw that is not in scope.

image.png

image.png

According to the UG, we have also specified what an index is, and with the current differentiated error message, it is distinguishable and doesn't bring great inconvenience to users when using it.

image.png

Feature flaw justification:

image.png

Not In Scope justification:

The improved error messages can be delayed to further iterations, because as seen above, it does not bring inconvenience or ambiguity to users. Furthermore, current app does not crash and is still working fine. Thus we feel that this is Not In Scope, hope this clarifies! Thank you

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]