search

mer-hybris / geoclue-providers-hybris

GNU Lesser General Public License v2.1
2 stars 17 forks source link

hal: Handle not being able to set the SUPL server. #44

Closed MagneFire closed 1 year ago

MagneFire commented 1 year ago

https://github.com/mer-hybris/geoclue-providers-hybris/commit/e982cf94047993e5868d44307f4a38f1b89500ea added support for overriding/setting the SUPL server. This could however lead to a crash when AGPS isn't actually available. Handle this by returning an error instead of crashing.

Signed-off-by: Darrel Griët dgriet@gmail.com

mlehtima commented 1 year ago

Otherwise looks good but in other places the code uses "if (m_agps)" style so maybe you could follow that style and return 0 at the end after having the current code inside "if (m_agps)"?

MagneFire commented 1 year ago

Thanks for the quick review!

Great finding on the consistency of the code styling. I've adjusted it to be conform with the style of the other functions.