search

mer-hybris / libgbinder

GLib-style interface to binder
BSD 3-Clause "New" or "Revised" License
51 stars 40 forks source link

Support libgbinder for Android 12 #83

Closed adglkh closed 2 years ago

adglkh commented 2 years ago

Adapt the change to service related protocol in Android 12.

adglkh commented 2 years ago

Just have a quick check the following commit from AOSP https://android.googlesource.com/platform/frameworks/native/+/16a4106cb7bc18d473a428d9f19c7561a21e3f06

I'm not quite sure why google folks have been constantly changing the service protocol this often. Maybe for the upcoming Android 13, people may have to switch the service protocol back to aidl3 rather than sticking to aidl4 which is going to be used in Android 12

monich commented 2 years ago

I'm not quite sure why google folks have been constantly changing the service protocol this often

Because they can :)

morphis commented 2 years ago

@monich any interest in pulling this PR? We would like to get rid of patches we maintain.

@adglkh can you get this rebased on latest master?

monich commented 2 years ago

@monich any interest in pulling this PR? We would like to get rid of patches we maintain.

Yes, we are definitely interested. Sorry about the delay. And unfortunately I have no Android 12 to test it against, I'll have to trust you on that one.

And it might be a good idea to submit smaller patches like this binder-dump thing (as long as they are self-sufficient) as separate PRs, those would get accepted faster.

monich commented 2 years ago

Overall looks quite promising

morphis commented 2 years ago

@monich Thanks!