mer-hybris / qt5-qpa-hwcomposer-plugin

Qt 5 QPA plugin for Droid hwcomposer
22 stars 45 forks source link

Hwcomposer 1.3 support #21

Closed morphis closed 10 years ago

morphis commented 10 years ago

Using the new sourceCropf property is required with hwcomposer 1.3 as implementations tend to require it and ignore the other integer based ones.

morphis commented 10 years ago

Please wait a moment with merging this. Follow up commit will fix support for Android < 4.3

sledges commented 10 years ago

Thank you, will wait. So we won't have to merge https://github.com/siteshwar/android_hardware_qcom_display/commit/95f7ed38297e505f59d45c820d109bb01797ba4e workaround thereafter ?

morphis commented 10 years ago

Right. Changes to the HAL should not be needed with but I didn't looked at this particular case as it's using MAX_DISPLAYS rather than HWC_NUM_DISPLAY_TYPES the other HALs are using.

morphis commented 10 years ago

Should be fine to be merged now. Build and runtime tested with 4.2 and 4.4 based builds.

thp commented 10 years ago

Added some minor comments. Rest looks good.

morphis commented 10 years ago

Sorry for that :) Fixed it and should be correct now.