Various fixes from LuneOS

mer-hybris / qt5-qpa-hwcomposer-plugin

Qt 5 QPA plugin for Droid hwcomposer

22 stars 45 forks source link

Various fixes from LuneOS #80

Closed Herrie82 closed 3 years ago

Herrie82 commented 5 years ago

Add support for changes introduced in Qt 5.8 and Qt 5.12
Make systrace optional
Add rotation support based on sensors
Fix build with Android 4.4.x

Signed-off-by: Herman van Hazendonk github.com@herrie.org

Herrie82 commented 4 years ago

@sledges Any objections to merging this as is? Both LuneOS and AsteroidOS are on newer Qt and could use this in the main branch instead of keeping patches ourselves.

rinigus commented 4 years ago

Any plans to merge this, would be handy to get higher Qt support and make systrace optional.

I used this PR and made few more changes to bump it to 5.14 in https://github.com/nemomobile-ux/qt5-qpa-hwcomposer-plugin/tree/nemo-dev. Thanks for your work on it!

mlehtima commented 4 years ago

Also consider following the commit message formatting used in this repo.

rinigus commented 4 years ago

Few additional changes that could be useful in this context:

https://github.com/mer-hybris/qt5-qpa-hwcomposer-plugin/commit/1424e647f7f18ffd0831da9eb51a015dff85abfa As hwcomposer/hwcomposer_backend_v20.cpp is also including <private/qsystrace_p.h>, I moved your dummy QSystrace into a separate header and included it in the both backends. In addition, it adds the same platformWindow approach for deliverUpdateRequest.
https://github.com/mer-hybris/qt5-qpa-hwcomposer-plugin/commit/c96f512fd5409f35bd4525a475028c13f27c76d7 Bumps it to 5.13+ with the replacement for screenAdded/destroyScreen

Herrie82 commented 4 years ago

@mlehtima I will rework it a bit. Give me a little time for build testing at my end as well.

Herrie82 commented 4 years ago

@mlehtima @rinigus Updated, squashed some commits, fixed formatting, added the commits mentioned by @rinigus as well and updated the commit messages. Builds OK on LuneOS side with Qt 5.15

mlehtima commented 4 years ago

Would it be possible to rebase the changes in a way to get rid of the merge commit currently in the PR?

sledges commented 4 years ago

Would it be possible to rebase the changes in a way to get rid of the merge commit currently in the PR?

Could you please also drop the ':' from the commits, [hwcomposer]: ... -> [hwcomposer] ...

mlehtima commented 4 years ago

Also something went wrong in rebase, now it shows duplicates of already included changes from master branch.

Herrie82 commented 4 years ago

Would it be possible to rebase the changes in a way to get rid of the merge commit currently in the PR?

Could you please also drop the ':' from the commits, [hwcomposer]: ... -> [hwcomposer] ...

Done

Herrie82 commented 4 years ago

Also something went wrong in rebase, now it shows duplicates of already included changes from master branch.

@mlehtima Yeah was still working on it, now force pushed a rebased one with just 6 commits. If anything still needs reworking, let me know.