Open Logic-gate opened 3 years ago
I'm certainly no expert, but isn't a DisplayError of 2 just kErrorNotSupported (and the "Prepare Failed..." message will only be printed in the specific case where the error is NOT a permissions error)?
Found the 8998 file (also there, used the 8.1 release ones), here is a diff between 8996 and 8998:
https://editor.mergely.com/2V4STLS7/
These are the files: https://android.googlesource.com/platform/hardware/qcom/display/+/android-8.1.0_r10/msm8996/sdm/libs/hwc2/hwc_display.cpp https://android.googlesource.com/platform/hardware/qcom/display/+/android-8.1.0_r10/msm8998/sdm/libs/hwc2/hwc_display.cpp
Hope this can help.
I'm certainly no expert, but isn't a DisplayError of 2 just kErrorNotSupported (and the "Prepare Failed..." message will only be printed in the specific case where the error is NOT a permissions error)?
Yes, it was pointed out to me that the error in question is not permission related. link
Found the 8998 file (also there, used the 8.1 release ones), here is a diff between 8996 and 8998:
https://editor.mergely.com/2V4STLS7/
These are the files: https://android.googlesource.com/platform/hardware/qcom/display/+/android-8.1.0_r10/msm8996/sdm/libs/hwc2/hwc_display.cpp https://android.googlesource.com/platform/hardware/qcom/display/+/android-8.1.0_r10/msm8998/sdm/libs/hwc2/hwc_display.cpp
Hope this can help.
Cheers,
great to hear someone working on this. thanks!
Ahoy Sailors, and greeting to all...
I am working on HDMI support and came across an issue that has been slowly driving me mad.
I found
PrepareLayerStack
(for msm8996, Pro1 has msm8998) here which seems to indicate a permission error; i have already given/sys/devices/virtual/graphics/fb2~fb1/*
0664
during testing, and even went as far as trying0777
just to make sure; what's also maddening is that theqcom.early_boot.sh
on the Pro1 (device I am testing on) already has proper permissions for hdmi support....but they seem to be ignored?!!I couldn't find much on
CompManager::Prepare
norScalarConfig::GetPipeScaleSettingsInfo
but I am assuming they are resolution scaling problems. PIC, note that the background color is that of my phone and the touchscreen is responsive, as in swiping left or right works.I would very much appreciate any feedback...literally any feedback.
UPDATE:
here's the full log pastebin