mer-hybris / qt5-qpa-hwcomposer-plugin

Qt 5 QPA plugin for Droid hwcomposer
22 stars 45 forks source link

Initial support for Qt6 #96

Closed Herrie82 closed 1 year ago

Herrie82 commented 2 years ago

In Qt6 some things with regards to graphics and OpenGL have been moved around a bit. Update the qmake and various header and source files to take care of these changes.

Signed-off-by: Herman van Hazendonk github.com@herrie.org

Herrie82 commented 2 years ago

Build checked on Qt 5.15.2 and Qt 6.3.0. It might be good to rename this component to a more generic qt-qpa-hwcomposer-plugin as well instead of naming is qt5 specifically.

Herrie82 commented 2 years ago

@mlehtima @JamiKettunen Any thoughts or comments on this one?

JamiKettunen commented 1 year ago

I suppose a port to CMake would be nice but that could be a lot of work, not sure, qmake should stay in the past :p On the other hand SFOS is still in the past with Qt 5.6 and I'm not sure how CMake integration was with that old version hm. maintaining both qmake and CMake build systems at the same time could be done as I don't see much of any changes to the existing .pro files withing the last 2 years.

Also +1 for the rename to qt-qpa-hwcomposer-plugin when this gets merged.

mlehtima commented 1 year ago

Forgot about this PR, I need to verify that it builds without issues with Qt currently used in Sailfish OS but otherwise seems ok.

Tofee commented 1 year ago

@mlehtima The commit https://github.com/mer-hybris/qt5-qpa-hwcomposer-plugin/pull/96/commits/6577623330c40114f6f64defc6138769e5548863 should hopefully fix the build for Qt 5.6.

mlehtima commented 1 year ago

Seems to build now without issues with Qt 5.6.