New regions creating issues in Patch object

meraki-analytics / cassiopeia

An all-inclusive Python framework for the Riot Games League of Legends API. Cass focuses on making the data easy and fun to work with, while providing all the tools necessary to create a website or do data analysis.

MIT License

552 stars 135 forks source link

New regions creating issues in Patch object #237

Closed xEcEz closed 6 years ago

xEcEz commented 6 years ago

An error is thrown when calling:

 Patch.__load__(cls)

It seems to be due to new region keys:

  File "/usr/local/lib/python3.6/dist-packages/cassiopeia_championgg/__init__.py", line 21, in championgg
    patch = Patch.from_str(patch_name, region=self.region)
  File ".../cassiopeia/core/patch.py", line 48, in from_str
    cls.__load__()
  File ".../cassiopeia/core/patch.py", line 82, in __load__
    start = arrow.get(patch["start"] + shifts[region.platform.value]).to(region.timezone)
KeyError: 'ID1'

jjmaldonis commented 6 years ago

That's not great. We'll need to get the offsets for the new regions (indonesia, thailand, etc) to fix this, but I don't have access. For now, to fix this issue you can delete the new regions and platforms in the data.py file.

jjmaldonis commented 6 years ago

Fixed by a commit in another repo: https://github.com/CommunityDragon/Data/commit/b033fdf76781e8440cbd77b2611ffce0e960498e