Closed rdavis0 closed 1 year ago
Hi @rdavis0, it seems like you are working quite heavily with the data and would like to see some improvements. Are you interested in contributing?
@jjmaldonis Yes, I'm planning to! Currently knee-deep in the project I'm using the data for, but some of these issues will become high priority for me once I tackle a few more milestones.
Awesome very happy to hear it! It's always fun to be knee-deep in a project. Rob and I are heads-down working on a new product for Meraki as well, so we haven't been putting time into the lolstaticdata project. Your contributions would be greatly appreciated not only by us, but by everyone who uses this. You may have seen on the discord that a good number of people use it, so your contributions will be immediately used and appreciated by a lot of people.
We would love to add you to our contributors section, so please include that in any PR you make! I need to go back and update that as well.
Fixed by #57
In items.json, the
passives[index].stats.movespeed
stat is set to just0.0
for all items, as opposed to being an object with various properties for how the stat may be calculated. In cases like Zeal3086
, which has a passive movespeed bonus, the bonus cannot be read from the item.