search

meraki-analytics / lolstaticdata

Accurate League of Legends static data for champions and items
MIT License
63 stars 22 forks source link

Grab ability range from wiki #68

Open and-zheng opened 1 year ago

and-zheng commented 1 year ago

Abilities are only tracking target range right now, which directional casted abilities don't have. Added a line to grab ability range from the wiki. Consider making target range the same as cast range for directional casted abilities?

DarkIntaqt commented 1 year ago

Hi, you may want to add this to the champion model file too : ) https://github.com/meraki-analytics/lolstaticdata/blob/5843dd585c4f0c5fa0fa94ae97b912931f472314/lolstaticdata/champions/modelchampion.py#L163

jjmaldonis commented 1 year ago

Hey @and-zheng, can you please add the range to the Ability class as well? Without it, the code will break.

and-zheng commented 9 months ago

Just did, thanks for the notice.