search

meraki-analytics / lolstaticdata

Accurate League of Legends static data for champions and items
MIT License
63 stars 22 forks source link

Some chroma entries are "null" #71

Closed rico-vz closed 6 months ago

rico-vz commented 11 months ago

In champions.json it seems like some chroma entries are just null. Example: Looking at Lunar Beast Annie, there are 7 entries inside "chromas" which match the amount of chromas that Lunar Beast Annie has, however each entry is just null.

13  
name "Lunar Beast"
id 1013
isBase false
availability "Legacy"
formatName "Lunar Beast"
lootEligible true
cost 1350
sale 0
distribution null
rarity "Epic"
chromas  
0 null
1 null
2 null
3 null
4 null
5 null
6 null

For other skins like Resistance Yorick only 1 chroma (number 3) is null, and the rest are fine.

Full list of null chroma entries:

Found a nulled out chroma for: Lunar Beast Annie
Found a nulled out chroma for: Lunar Beast Annie
Found a nulled out chroma for: Lunar Beast Annie
Found a nulled out chroma for: Lunar Beast Annie
Found a nulled out chroma for: Lunar Beast Annie
Found a nulled out chroma for: Lunar Beast Annie
Found a nulled out chroma for: Pool Party Braum
Found a nulled out chroma for: Star Guardian Ekko
Found a nulled out chroma for: Bewitching Elise
Found a nulled out chroma for: Pulsefire Ezreal
Found a nulled out chroma for: Pulsefire Ezreal
Found a nulled out chroma for: Pulsefire Ezreal
Found a nulled out chroma for: Cafe Cuties Gwen
Found a nulled out chroma for: Cafe Cuties Gwen
Found a nulled out chroma for: Warring Kingdoms Jarvan IV
Found a nulled out chroma for: Dark Star Jarvan IV
Found a nulled out chroma for: Worlds 2018 Kha'Zix
Found a nulled out chroma for: Worlds 2018 Kha'Zix
Found a nulled out chroma for: Worlds 2018 Kha'Zix
Found a nulled out chroma for: Worlds 2018 Kha'Zix
Found a nulled out chroma for: High Noon Lucian
Found a nulled out chroma for: Elementalist Lux
Found a nulled out chroma for: Elementalist Lux
Found a nulled out chroma for: Elementalist Lux
Found a nulled out chroma for: Elementalist Lux
Found a nulled out chroma for: Elementalist Lux
Found a nulled out chroma for: Elementalist Lux
Found a nulled out chroma for: Elementalist Lux
Found a nulled out chroma for: Elementalist Lux
Found a nulled out chroma for: Elementalist Lux
Found a nulled out chroma for: Porcelain Lux
Found a nulled out chroma for: Beezahar Malzahar
Found a nulled out chroma for: Gun Goddess Miss Fortune
Found a nulled out chroma for: Gun Goddess Miss Fortune
Found a nulled out chroma for: Gun Goddess Miss Fortune
Found a nulled out chroma for: High Noon Mordekaiser
Found a nulled out chroma for: AstroNautilus Nautilus
Found a nulled out chroma for: La Ilusión Nidalee
Found a nulled out chroma for: Dark Star Orianna
Found a nulled out chroma for: Worlds 2014 Shyvana
Found a nulled out chroma for: DJ Sona
Found a nulled out chroma for: DJ Sona
Found a nulled out chroma for: Dark Star Thresh
Found a nulled out chroma for: Spirit Guard Udyr
Found a nulled out chroma for: Spirit Guard Udyr
Found a nulled out chroma for: Spirit Guard Udyr
Found a nulled out chroma for: Spirit Guard Udyr
Found a nulled out chroma for: Resistance Yorick
bangingheads commented 10 months ago

This was an issue with the wiki having bad IDs which I went through and fixed them all, with handling of unused and identification being added with #72

Elementalist Lux is an issue as they are not actual chromas and will need special handling since there's not chroma data or it will need to be ignored

jjmaldonis commented 6 months ago

This seems to be fixed now. Closing this issue. Feel free to reopen if the chromas are still missing.