search

meraki-analytics / lolstaticdata

Accurate League of Legends static data for champions and items
MIT License
63 stars 22 forks source link

update 'get_item_plaintext' URL to the latest version #94

Open ruoyu-lu opened 1 month ago

ruoyu-lu commented 1 month ago

The get_item_plaintext function previously utilized an outdated version in its URL path, which led to failures when attempting to retrieve item JSON data files. The filename in the latest version is lol.stringtable.json. This update modifies the URL to align with the newest version, ensuring successful data retrieval.

jjmaldonis commented 1 month ago

Is it necessary to remove the version from the string and always use the latest? That isn't desirable behavior so hopefully it's not necessary.

ruoyu-lu commented 1 month ago

I just saw that as of version 14.15, the official filename has changed from 'main.stringtable.json' to 'lol.stringtable.json', which will prevent the current project from pulling the file, so I think it's fine to just use the latest version of json

PushaBe commented 1 week ago

isn't it already fixed here anyway? so there is a room to choose version for the plaintext but not for the items themselves as far as I see