search

meraki-analytics / orianna

A Java framework for the Riot Games League of Legends API (http://developer.riotgames.com/).
MIT License
182 stars 56 forks source link

rate limiter code speculation and maybe allow custom listeners to be added to the rate limiter #107

Closed omarathon closed 4 years ago

omarathon commented 5 years ago

last 2 commits are supposed to be together sorry

overriding the interfaces without an implementation or change in signature seemed odd to me but it might have had a reason.

last 2 commits are just to convey the kind of functionality that would be nice from a rate limiter listener.

omarathon commented 5 years ago

I think actually being able to listen for arbitrary response codes would be much better.